Skip to content

NIAD-3208: CustomTrustStore refactoring to exclude weird dependencies #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ORybak5 merged 12 commits into from
Jan 23, 2025
Merged

NIAD-3208: CustomTrustStore refactoring to exclude weird dependencies #1054

ORybak5 merged 12 commits into from
Jan 23, 2025

Conversation

@ORybak5
Copy link
Contributor

@ORybak5 ORybak5 commented Jan 13, 2025

What

Please include a summary of the changes and the related issue

Why

Please include details of the reasoning for these changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@ORybak5 ORybak5 requested a review from adrianclay January 22, 2025 13:37
@ORybak5 ORybak5 marked this pull request as ready for review January 22, 2025 13:38
adrianclay
adrianclay reviewed Jan 22, 2025
View reviewed changes
adrianclay
adrianclay reviewed Jan 22, 2025
View reviewed changes
service/src/test/java/uk/nhs/adaptors/gp2gp/common/configuration/CustomTrustStoreTest.java

@BeforeEach
void prepare() {
customTrustStore = new CustomTrustStore(s3Client);
Copy link
Contributor

@adrianclay adrianclay Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, why not put it in the existing @BeforeAll ?

Copy link
Contributor Author

@ORybak5 ORybak5 Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can do

@ORybak5 ORybak5 requested a review from adrianclay January 23, 2025 09:58
@github-actions
Copy link

github-actions bot commented Jan 23, 2025

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 2
class surviving killed
🧟uk.nhs.adaptors.gp2gp.common.configuration.AppInitializer 3 2

See https://pitest.org

@ORybak5 ORybak5 changed the title NIAD-3208: refactoring NIAD-3208: CustomTrustStore refactoring to exclude weird dependencies Jan 23, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 23, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ORybak5 ORybak5 requested a review from adrianclay January 23, 2025 11:34
@ORybak5 ORybak5 merged commit a74b20d into main Jan 23, 2025
14 of 15 checks passed
@ORybak5 ORybak5 deleted the NIAD-3208-folloup-refactoring branch January 23, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adrianclay adrianclay adrianclay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ORybak5 @adrianclay